Switch snapshot ci to new app and rework notification design #938
Conversation
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
rolnico
changed the title
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
|
Once merged, powsybl/powsybl-dev-tools#120 should be adapted to reflect the integration branch naming pattern change. |
Co-authored-by: Olivier Perrin <[email protected]> Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
| core_snapshot_version=$(echo "$core_version" | grep -q SNAPSHOT && echo "$core_version" || echo "$core_version-SNAPSHOT") | ||
|
|
||
| # Find if an integration branch exists | ||
| INTEGRATION_BRANCH=$(git ls-remote --heads "$repo" | grep -E "refs/heads/integration/powsyblcore-$core_snapshot_version" | sed 's/.*refs\/heads\///') |
There was a problem hiding this comment.
After consulting the main repositories' maintainers, it was decided to keep non-protected branches for the CI snapshot process.
Can you change this script to use refs/heads/ci/core-$core_snapshot_version instead ("integration" -> "ci" + "powsyblcore" -> "core") and to remove references to "integration"?
Signed-off-by: Nicolas Rol <[email protected]>
# Conflicts: # .github/workflows/snapshot-ci.yml
Signed-off-by: Nicolas Rol <[email protected]>
|
|
|
|
* rework CI snapshot * add print * fix jobs name * format results * change references from integration to snapshot Signed-off-by: Nicolas Rol <[email protected]> Signed-off-by: Naledi EL CHEIKH <[email protected]>
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
CI uses some action to format slack notification
What is the new behavior (if this is a feature change)?
Better format
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Existing integration branches for the current snapshot version of powsybl-core should be renamed by adding the prefix
ci/core-. (For instance,6.7.0-SNAPSHOT=>ci/core-6.7.0-SNAPSHOT).Other information:
6.6.0-SNAPSHOT). Now their name should be prefixed withintegration/powsyblcore-. In our previous example, the branches must be calledintegration/powsyblcore-6.6.0-SNAPSHOT.As a consequence, only maintainers can create these branches or force-push into them (see the branching strategy documentation).